Petals CDK

Support attachment in the Petals components following the JBI specification

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 5.0.3
  • Fix Version/s: None
  • Component/s: None
  • Security Level: Public
  • Description:

    Attachement are not handled correctly by the Petals components. Currently, the attachment is dissociated of the payload. So, following JBI specification, each attachment MUST be referenced by a xop:Include element in the XML body of the message content.

  • Environment:
    no environment
  1. Patch.java
    (8 kB)
    Vincent Zurczak
    Thu, 21 Oct 2010 - 20:03:57 +0200

Activity

Hide
Vincent Zurczak added a comment - Thu, 21 Oct 2010 - 19:29:00 +0200 - edited

Would it be possible to complete the javadoc of the class MtomUtil?

Besides, some functions should be changed.
In particular in #extractAttachmentRootElement.
This method searches an element called "attachments" and assumes all the attachments are located below.
This is not explained in the java doc.
And this might be the behavior in the Talend SE and in the FileTransfer BC, but in the Jsr-181, it does not work this way. Other components might work differently too.

The method #extractAttachmentsIdFromPayload is useful.
But there could be another one more useful: the one that gets all the mappings at once.
I will attach an implementation then. Could you add it in the implementation (if you judge it a useful addition)?

Show
Vincent Zurczak added a comment - Thu, 21 Oct 2010 - 19:29:00 +0200 - edited Would it be possible to complete the javadoc of the class MtomUtil? Besides, some functions should be changed. In particular in #extractAttachmentRootElement. This method searches an element called "attachments" and assumes all the attachments are located below. This is not explained in the java doc. And this might be the behavior in the Talend SE and in the FileTransfer BC, but in the Jsr-181, it does not work this way. Other components might work differently too. The method #extractAttachmentsIdFromPayload is useful. But there could be another one more useful: the one that gets all the mappings at once. I will attach an implementation then. Could you add it in the implementation (if you judge it a useful addition)?
Hide
Vincent Zurczak added a comment - Thu, 21 Oct 2010 - 20:03:57 +0200

A new method to add in the utilities.

Show
Vincent Zurczak added a comment - Thu, 21 Oct 2010 - 20:03:57 +0200 A new method to add in the utilities.
Hide
Mathieu Carrolle added a comment - Tue, 26 Oct 2010 - 09:41:14 +0200

Very good idea Vincent.
I will add your implementation.

Thank you.

Show
Mathieu Carrolle added a comment - Tue, 26 Oct 2010 - 09:41:14 +0200 Very good idea Vincent. I will add your implementation. Thank you.

People

Dates

  • Created:
    Mon, 12 Jul 2010 - 14:19:50 +0200
    Updated:
    Tue, 26 Oct 2010 - 09:47:54 +0200