Petals Distribution

Put JCL/LOG4J to SLF4J and SLF4J to JUL bridges in the system classloader

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 5.0.0-RC-1
  • Fix Version/s: 5.0.0
  • Component/s: None
  • Security Level: Public
  • Description:
    Hide

    Since PETALSESBCONT-424, slf4j-api and slf4j-jdk14 will be introduced in the system classloader (see comments).
    It makes sense to also include jcl-over-slf4j and log4j-over-slf4j that contains classes that replace the commons-logging and log4j classes.

    Because slf4j has a very strict policy about changing API, we can be assured that putting them in the system classloader should not introduces bug.
    Basically we will use latest version of 1.7.21 that is backward compatible with slf4j api at least since 1.6 (which is very old).

    Show
    Since PETALSESBCONT-424, slf4j-api and slf4j-jdk14 will be introduced in the system classloader (see comments). It makes sense to also include jcl-over-slf4j and log4j-over-slf4j that contains classes that replace the commons-logging and log4j classes. Because slf4j has a very strict policy about changing API, we can be assured that putting them in the system classloader should not introduces bug. Basically we will use latest version of 1.7.21 that is backward compatible with slf4j api at least since 1.6 (which is very old).
  • Environment:
    -

Issue Links

Depends
 

Activity

Ascending order - Click to sort in descending order
Victor NOËL made changes - Tue, 31 May 2016 - 13:17:07 +0200
Field Original Value New Value
Summary Put SLF4J to JUL bridges in the system classloader Put JCL/LOG4J to SLF4J and SLF4J to JUL bridges in the system classloader
Assignee Christophe DENEUX [ cdeneux ] Victor NOËL [ vnoel ]
Priority Blocker [ 1 ]
Victor NOËL made changes - Tue, 31 May 2016 - 13:17:15 +0200
Status New [ 10000 ] Open [ 10002 ]
Priority Blocker [ 1 ] Major [ 3 ]
Victor NOËL made changes - Tue, 31 May 2016 - 13:17:48 +0200
Link This issue blocks PETALSESBCONT-424 [ PETALSESBCONT-424 ]
Victor NOËL made changes - Tue, 31 May 2016 - 13:18:17 +0200
Link This issue blocks PETALSDISTRIB-135 [ PETALSDISTRIB-135 ]
Victor NOËL made changes - Tue, 31 May 2016 - 13:18:28 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Victor NOËL made changes - Tue, 31 May 2016 - 13:19:11 +0200
Fix Version/s 5.0.0 [ 10631 ]
Description Since PETALSESBCONT-424 (and also PETALSDISTRIB-135), slf4j-api and slf4j-jdk14 will be introduced in the system classloader (see comments).
It makes sense to also include jcl-over-slf4j and log4j-over-slf4j that contains classes that replace the commons-logging and log4j classes.

Because slf4j has a very strict policy about changing API, we can be assured that putting them in the system classloader should not introduces bug.
Basically we will use latest version of 1.7.21 that is backward compatible with slf4j api at least since 1.6 (which is very old). 		Since PETALSESBCONT-424, slf4j-api and slf4j-jdk14 will be introduced in the system classloader (see comments).
It makes sense to also include jcl-over-slf4j and log4j-over-slf4j that contains classes that replace the commons-logging and log4j classes.

Because slf4j has a very strict policy about changing API, we can be assured that putting them in the system classloader should not introduces bug.
Basically we will use latest version of 1.7.21 that is backward compatible with slf4j api at least since 1.6 (which is very old).
Hide
Permalink
Victor NOËL added a comment - Tue, 31 May 2016 - 13:21:00 +0200

This means that all these dependencies can be removed from components, extensions and mutable implementations.

(but if we don't, it's not a problem though)

Show
Victor NOËL added a comment - Tue, 31 May 2016 - 13:21:00 +0200 This means that all these dependencies can be removed from components, extensions and mutable implementations. (but if we don't, it's not a problem though)
Hide
Permalink
Christophe DENEUX added a comment - Tue, 31 May 2016 - 15:57:25 +0200

Yes removed dependencies. Don't forget to create JIRA issues at component level to remove dependencies.

Show
Christophe DENEUX added a comment - Tue, 31 May 2016 - 15:57:25 +0200 Yes removed dependencies. Don't forget to create JIRA issues at component level to remove dependencies.
Christophe DENEUX made changes - Wed, 1 Jun 2016 - 10:19:10 +0200
Link This issue blocks PETALSSLACTIVMQ-3 [ PETALSSLACTIVMQ-3 ]
Christophe DENEUX made changes - Wed, 1 Jun 2016 - 10:26:04 +0200
Link This issue blocks PETALSSLJBOSS-2 [ PETALSSLJBOSS-2 ]
Christophe DENEUX made changes - Wed, 1 Jun 2016 - 10:29:18 +0200
Link This issue blocks PETALSSLJONAS-3 [ PETALSSLJONAS-3 ]
Victor NOËL made changes - Wed, 1 Jun 2016 - 11:20:46 +0200
Status In Progress [ 10003 ] Resolved [ 10004 ]
Resolution Fixed [ 1 ]
Transition Status Change Time Execution Times Last Executer Last Execution Date
New New Open Open
43s
1
Victor NOËL
Tue, 31 May 2016 - 13:17:15 +0200
Open Open In Progress In Progress
1m 13s
1
Victor NOËL
Tue, 31 May 2016 - 13:18:28 +0200
In Progress In Progress Resolved Resolved
22h 2m
1
Victor NOËL
Wed, 1 Jun 2016 - 11:20:46 +0200



People

Dates

  • Created:
    Tue, 31 May 2016 - 13:16:32 +0200
    Updated:
    Wed, 1 Jun 2016 - 11:20:46 +0200
    Resolved:
    Wed, 1 Jun 2016 - 11:20:46 +0200
Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Petals ESB. Try JIRA - bug tracking software for your team.