Petals CDK

Technical errors should NOT be transformed to Fault, and even less SOAPFault

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 5.4.2
  • Fix Version/s: 5.5.0
  • Component/s: None
  • Security Level: Public
  • Description:

    As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

    And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

  • Environment:
    -

Issue Links

Activity

Victor NOËL made changes - Fri, 24 Apr 2015 - 15:04:21 +0200
Field Original Value New Value
Assignee Christophe DENEUX [ cdeneux ] Victor NOËL [ vnoel ]
Victor NOËL made changes - Fri, 24 Apr 2015 - 15:04:43 +0200
Link This issue blocks PETALSDISTRIB-133 [ PETALSDISTRIB-133 ]
Victor NOËL made changes - Fri, 24 Apr 2015 - 16:40:43 +0200
Priority Critical [ 2 ]
Victor NOËL made changes - Tue, 28 Apr 2015 - 12:35:30 +0200
Link This issue blocks PETALSBCSOAP-145 [ PETALSBCSOAP-145 ]
Victor NOËL made changes - Tue, 28 Apr 2015 - 12:38:04 +0200
Link This issue blocks PETALSSEJSR-28 [ PETALSSEJSR-28 ]
Victor NOËL made changes - Tue, 28 Apr 2015 - 12:46:04 +0200
Status New [ 10000 ] Open [ 10002 ]
Victor NOËL made changes - Tue, 28 Apr 2015 - 14:44:07 +0200
Description As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

SOAP11FaultClientException can be safely removed from the CDK.
As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK.

Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault.
But that shouldn't be done using Java exceptions.
Victor NOËL made changes - Tue, 28 Apr 2015 - 14:52:56 +0200
Description As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK.

Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault.
But that shouldn't be done using Java exceptions.
As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK.

Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault.
But that shouldn't be done using Java exceptions (except maybe for the case of the POJO that seems to be relying on it... maybe we should move that "exception-based fault handling" logic to the pojo if we think current users of the component are exploiting them! (or provides an easy to use alternative)).
Christophe DENEUX made changes - Fri, 1 May 2015 - 10:34:07 +0200
Link This issue depends on PETALSCDK-133 [ PETALSCDK-133 ]
Christophe DENEUX made changes - Fri, 1 May 2015 - 10:36:04 +0200
Fix Version/s 5.5.0 [ 10406 ]
Priority Critical [ 2 ] Major [ 3 ]
Victor NOËL made changes - Mon, 11 May 2015 - 16:29:03 +0200
Link This issue blocks PETALSESBCONT-334 [ PETALSESBCONT-334 ]
Victor NOËL made changes - Thu, 21 May 2015 - 15:03:32 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Hide
Victor NOËL added a comment - Thu, 21 May 2015 - 17:06:57 +0200

The first commit left the various exceptions around FaultException but do not use them internally anymore.

They are there to keep the components using them working as they were, but they still need to be updated!

Show
Victor NOËL added a comment - Thu, 21 May 2015 - 17:06:57 +0200 The first commit left the various exceptions around FaultException but do not use them internally anymore. They are there to keep the components using them working as they were, but they still need to be updated!
Hide
Victor NOËL added a comment - Thu, 21 May 2015 - 17:09:54 +0200

Forked the second part of this issue in PETALSCDK-134.

Show
Victor NOËL added a comment - Thu, 21 May 2015 - 17:09:54 +0200 Forked the second part of this issue in PETALSCDK-134.
Victor NOËL made changes - Thu, 21 May 2015 - 17:09:54 +0200
Description As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.

FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK.

Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault.
But that shouldn't be done using Java exceptions (except maybe for the case of the POJO that seems to be relying on it... maybe we should move that "exception-based fault handling" logic to the pojo if we think current users of the component are exploiting them! (or provides an easy to use alternative)).
As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

And Fault should NOT be SOAPFault, this is the role of the BC SOAP to do so, see: PETALSBCSOAP-145.
Victor NOËL made changes - Thu, 21 May 2015 - 17:10:06 +0200
Status In Progress [ 10003 ] Resolved [ 10004 ]
Resolution Fixed [ 1 ]
Victor NOËL made changes - Thu, 21 May 2015 - 17:11:21 +0200
Link This issue blocks PETALSCDK-133 [ PETALSCDK-133 ]
Victor NOËL made changes - Thu, 21 May 2015 - 17:11:29 +0200
Link This issue depends on PETALSCDK-133 [ PETALSCDK-133 ]
Victor NOËL made changes - Fri, 22 May 2015 - 13:00:39 +0200
Link This issue blocks PETALSCDK-134 [ PETALSCDK-134 ]
Transition Status Change Time Execution Times Last Executer Last Execution Date
New New Open Open
3d 21h 42m
1
Victor NOËL
Tue, 28 Apr 2015 - 12:46:04 +0200
Open Open In Progress In Progress
23d 2h 17m
1
Victor NOËL
Thu, 21 May 2015 - 15:03:32 +0200
In Progress In Progress Resolved Resolved
2h 6m
1
Victor NOËL
Thu, 21 May 2015 - 17:10:06 +0200



People

Dates

  • Created:
    Fri, 24 Apr 2015 - 15:03:36 +0200
    Updated:
    Fri, 22 May 2015 - 13:00:39 +0200
    Resolved:
    Thu, 21 May 2015 - 17:10:06 +0200