Petals CDK

Updated the description.

Postponed to 5.5.1 or upper

Ok,

and I agree with the second point, let's discuss that during weekly meeting since it's not straightforward.

If you are able to use only a thread pool to accept and process message, and taking account the resource constraints, it's ok for me. Your thread pool should be sized from 10 to 50 by default as the current message processor thread pool. In my mind, you should update the current message processor thread pool to avoid too changes for our users (configuration, monitoring)

When no resource is available it should be better to return an error according to the MEP. Dropping message was an easy way but it can be problematic if no timeout is set by the caller: it will wait indefinitely a reply or ack.

Ok, but why didn't we get just a pool of threads that accept and then directly process? I don't see how it is different… is it?

One difference I see is the fact that acceptor threads wait if there is no available processor threads, and then they drop the messages!
Does it mean we have as a requirement : messages must be dropped if there is no resources available to process them?

I'm trying to clarify the requirements we are trying to achieve independently of the current implementation that seems to have been written by many people at different times

The mechanism based on acceptors/workers was written because of:

• DeleveryChannel.accept() is a blocking API,
• to limit resource consumption when there is no message to process (only few threads are running),
• to limit thread creations (a thread will process several messages until no message is available during a given duration)

And can you remind me the rationale behind having two sets of threads: one for accepting messages and one for processing them?

Thanks

Yes, you can remove the defect if it has no more sens. Don't forget to update user documentation.

Question for you Christophe: are the classes in org.ow2.petals.component.framework.monitoring.defect only used to notify in case there is no thread available in the acceptor thread pool?

If the acceptor thread pool is refactored and we can be sure there always be thread available, can we remove the classes in org.ow2.petals.component.framework.monitoring.defect?

Thanks