[#PETALSBCSOAP-65] Algorithmic error in function isLocalAddress() from NetworkUtil - Petals Link JIRA

Details

Type: Bug
Status: Resolved
Priority: Critical
Resolution: Fixed
Affects Version/s: 4.0.4
Fix Version/s: 4.0.5, 4.1
Component/s: None
Security Level: Public

Description:

Hide

In the current code, the value of 'result' can be overwritten by subsequent non-local addresses. Some 'true' result can be lost.

I suggest the following patch:

Index: src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java
===================================================================
--- src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java	(revision 16340)
+++ src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java	(working copy)
@@ -129,22 +129,23 @@
      * @return
      */
     public static boolean isLocalAddress(InetAddress address) {
-        boolean result = false;
         if (address != null) {
             try {
                 Enumeration<NetworkInterface> itfs = NetworkInterface.getNetworkInterfaces();
                 while (itfs.hasMoreElements()) {
                     NetworkInterface itf = itfs.nextElement();
                     Enumeration<InetAddress> iaenum = itf.getInetAddresses();
-                    while (iaenum.hasMoreElements() && !result) {
+                    while (iaenum.hasMoreElements()) {
                         InetAddress ia = iaenum.nextElement();
-                        result = ia.equals(address);
+                        if (ia.equals(address)) {
+							return true;
+						}
                     }
                 }
             } catch (SocketException e) {
             }
         }
-        return result;
+        return false;
     }
 
     /**

By the way, the management of SocketException is still problematic, because it can occur before every network interface has been scanned and make isLocalAddress() return false while it should have returned true.

Show

In the current code, the value of 'result' can be overwritten by subsequent non-local addresses. Some 'true' result can be lost. I suggest the following patch:

Index: src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java
===================================================================
--- src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java	(revision 16340)
+++ src/main/java/org/ow2/petals/binding/soap/util/NetworkUtil.java	(working copy)
@@ -129,22 +129,23 @@
      * @return
      */
     public static boolean isLocalAddress(InetAddress address) {
-        boolean result = false;
         if (address != null) {
             try {
                 Enumeration<NetworkInterface> itfs = NetworkInterface.getNetworkInterfaces();
                 while (itfs.hasMoreElements()) {
                     NetworkInterface itf = itfs.nextElement();
                     Enumeration<InetAddress> iaenum = itf.getInetAddresses();
-                    while (iaenum.hasMoreElements() && !result) {
+                    while (iaenum.hasMoreElements()) {
                         InetAddress ia = iaenum.nextElement();
-                        result = ia.equals(address);
+                        if (ia.equals(address)) {
+							return true;
+						}
                     }
                 }
             } catch (SocketException e) {
             }
         }
-        return result;
+        return false;
     }
 
     /**

By the way, the management of SocketException is still problematic, because it can occur before every network interface has been scanned and make isLocalAddress() return false while it should have returned true.

Environment:

All

Petals BC SOAP

Algorithmic error in function isLocalAddress() from NetworkUtil

Details

Activity

People

Dates